-
Notifications
You must be signed in to change notification settings - Fork 26
Implemented: order schema and its related schema used in the order taking reference from the moqui order schema(#2f2h74x) #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…king reference from the moqui order schema(#2f2h74x)
…ired and updated some parameters enumeration entity as required(#2f2h74x)
src/types/Identification.ts
Outdated
| @@ -0,0 +1,11 @@ | |||
| import { Enumeration } from "./index"; | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identifications can be for many different entities, Product, Party, Order etc.
Should we rename this to PartyIdentification ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense Sir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sir, Deleted this schema as renamed it to PartyIdentification schema and declared it in the Party.ts file instead of having a separate schema file.
src/types/Identification.ts
Outdated
| @@ -0,0 +1,11 @@ | |||
| import { Enumeration } from "./index"; | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider renaming to PartyIdentification?
We will have identifications for Products, Orders, Party etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes Sir. We have the same pattern in Moqui as well
https://demo.moqui.org/qapps/tools/Entity/DataEdit/EntityList?filterRegexp=Identification&viewOption=all&submitButton=submitButton
src/types/Order.ts
Outdated
| currencyUom?: Uom, | ||
| salesChannel?: Enumeration, | ||
| parts?: Array<OrderPart>, | ||
| notes?: Array<{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In current version, We decided to use communicationEvents for Notes.
Should we follow same pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a discussion with @dixitdeepak Sir on the pattern to be followed here, so concluded that we will be using commnicationEvents for storing the Notes and will be removing notes from the schema.
… deleted the identification schema(#2f2h74x)
…e usage of notes property(#2f2h74x)
Uh oh!
There was an error while loading. Please reload this page.