Skip to content

Conversation

@ymaheshwari1
Copy link
Contributor

@ymaheshwari1 ymaheshwari1 commented Jun 10, 2022

  • Removed some fields those are not needed in the order schema for app side
  • Declared different files for each dependent schema: Enumeration, Status, Identification, Geo, Party, ContactMech, Uom, Order

@@ -0,0 +1,11 @@
import { Enumeration } from "./index";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identifications can be for many different entities, Product, Party, Order etc.

Should we rename this to PartyIdentification ?

@dixitdeepak @adityasharma7

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense Sir

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sir, Deleted this schema as renamed it to PartyIdentification schema and declared it in the Party.ts file instead of having a separate schema file.

@@ -0,0 +1,11 @@
import { Enumeration } from "./index";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider renaming to PartyIdentification?

We will have identifications for Products, Orders, Party etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currencyUom?: Uom,
salesChannel?: Enumeration,
parts?: Array<OrderPart>,
notes?: Array<{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In current version, We decided to use communicationEvents for Notes.

Should we follow same pattern?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a discussion with @dixitdeepak Sir on the pattern to be followed here, so concluded that we will be using commnicationEvents for storing the Notes and will be removing notes from the schema.

@ymaheshwari1 ymaheshwari1 requested a review from patelanil June 14, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants